also trigger overflow FCW when going from overflow -> error - #161552

also trigger overflow FCW when going from overflow -> error

based on rust-lang#161341. This changes the FCW to also trigger if doubling the recursion limit changes things to an error.

Fixes bevyengine/bevy#25511

I am also changing `fn root_goal_may_hold_opaque_types_jank` to just use `evaluate_root_goal`. That isn't necessary for the example itself but we previously didn't do the FCW in there, which feels subtle and brittle. THis should just generally be more consistent

r? adwinwhite (or anyone else really)

Rollup of 24 pull requests

Successful merges:

 - #161586 (miri subtree update)
 - #161187 (add `Complex<T>` layout tests for straightforward targets)
 - #161524 (Put back `tests/rustdoc-gui/search-result-display.goml`)
 - #161592 (core: refactor tests/pattern.rs tests)
 - #161602 (Fix flakyness issue for `tests/rustdoc-gui/headers-color.goml`)
 - #152433 (Use `symlink_dir` to create junctions on Windows instead of trying to use symbolic links in `copy_link_internal`)
 - #155254 (Recover on attribute in use tree)
 - #158695 (Replace `CrateDump` with the Debug impl from `CStore`)
 - #159456 (Fix the reporting of layout normalization failures in transmute checks)
 - #159940 (Eliminate some buggy `unreachable!()`s in `expand_[option_]env()`)
 - #160452 (-Ctarget-feature is not unsafe (any more))
 - #161007 (tests/ui/union/union-nodrop.rs: fix typo "expressios")
 - #161166 (add crashtests [5/N], remove unused aux files )
 - #161294 (add crashtests [6/N])
 - #161552 (also trigger overflow FCW when going from overflow -> error)
 - #161569 (Bump cfg_aliases to 0.2.2)
 - #161573 (re-bless `pretty-std` on windows)
 - #161580 (Add codegen test for redundant bit mask after a range check)
 - #161588 (update eyre)
 - #161589 (std: reduce visibility of some internal OsStr related types)
 - #161598 ([Bootstrap] Pass exact CI `llvm-config` executable path)
 - #161601 (Path: use optimized is_empty() method)
 - #161604 (coretests: Add a few tests for backward multibyte predicate)
 - #161615 (interpret: make validate_c_variadic_compatible_ty public)

Rollup of 22 pull requests

Successful merges:

 - #161586 (miri subtree update)
 - #161187 (add `Complex<T>` layout tests for straightforward targets)
 - #161524 (Put back `tests/rustdoc-gui/search-result-display.goml`)
 - #161592 (core: refactor tests/pattern.rs tests)
 - #161602 (Fix flakyness issue for `tests/rustdoc-gui/headers-color.goml`)
 - #152433 (Use `symlink_dir` to create junctions on Windows instead of trying to use symbolic links in `copy_link_internal`)
 - #155254 (Recover on attribute in use tree)
 - #158695 (Replace `CrateDump` with the Debug impl from `CStore`)
 - #159456 (Fix the reporting of layout normalization failures in transmute checks)
 - #159940 (Eliminate some buggy `unreachable!()`s in `expand_[option_]env()`)
 - #160452 (-Ctarget-feature is not unsafe (any more))
 - #161007 (tests/ui/union/union-nodrop.rs: fix typo "expressios")
 - #161552 (also trigger overflow FCW when going from overflow -> error)
 - #161569 (Bump cfg_aliases to 0.2.2)
 - #161573 (re-bless `pretty-std` on windows)
 - #161580 (Add codegen test for redundant bit mask after a range check)
 - #161588 (update eyre)
 - #161589 (std: reduce visibility of some internal OsStr related types)
 - #161598 ([Bootstrap] Pass exact CI `llvm-config` executable path)
 - #161601 (Path: use optimized is_empty() method)
 - #161604 (coretests: Add a few tests for backward multibyte predicate)
 - #161615 (interpret: make validate_c_variadic_compatible_ty public)

Rollup merge of #161552 - lcnr:overflow-fcw-chain, r=adwinwhite

also trigger overflow FCW when going from overflow -> error

based on #161341. This changes the FCW to also trigger if doubling the recursion limit changes things to an error.

Fixes bevyengine/bevy#25511

I am also changing `fn root_goal_may_hold_opaque_types_jank` to just use `evaluate_root_goal`. That isn't necessary for the example itself but we previously didn't do the FCW in there, which feels subtle and brittle. THis should just generally be more consistent

r? adwinwhite (or anyone else really)

Rollup of 22 pull requests

Successful merges:

 - rust-lang/rust#161586 (miri subtree update)
 - rust-lang/rust#161187 (add `Complex<T>` layout tests for straightforward targets)
 - rust-lang/rust#161524 (Put back `tests/rustdoc-gui/search-result-display.goml`)
 - rust-lang/rust#161592 (core: refactor tests/pattern.rs tests)
 - rust-lang/rust#161602 (Fix flakyness issue for `tests/rustdoc-gui/headers-color.goml`)
 - rust-lang/rust#152433 (Use `symlink_dir` to create junctions on Windows instead of trying to use symbolic links in `copy_link_internal`)
 - rust-lang/rust#155254 (Recover on attribute in use tree)
 - rust-lang/rust#158695 (Replace `CrateDump` with the Debug impl from `CStore`)
 - rust-lang/rust#159456 (Fix the reporting of layout normalization failures in transmute checks)
 - rust-lang/rust#159940 (Eliminate some buggy `unreachable!()`s in `expand_[option_]env()`)
 - rust-lang/rust#160452 (-Ctarget-feature is not unsafe (any more))
 - rust-lang/rust#161007 (tests/ui/union/union-nodrop.rs: fix typo "expressios")
 - rust-lang/rust#161552 (also trigger overflow FCW when going from overflow -> error)
 - rust-lang/rust#161569 (Bump cfg_aliases to 0.2.2)
 - rust-lang/rust#161573 (re-bless `pretty-std` on windows)
 - rust-lang/rust#161580 (Add codegen test for redundant bit mask after a range check)
 - rust-lang/rust#161588 (update eyre)
 - rust-lang/rust#161589 (std: reduce visibility of some internal OsStr related types)
 - rust-lang/rust#161598 ([Bootstrap] Pass exact CI `llvm-config` executable path)
 - rust-lang/rust#161601 (Path: use optimized is_empty() method)
 - rust-lang/rust#161604 (coretests: Add a few tests for backward multibyte predicate)
 - rust-lang/rust#161615 (interpret: make validate_c_variadic_compatible_ty public)